Well, that's a matter of taste. Also, one should say 

use base "Exporter";

[download]
which is a better style imo than 
use Exporter;
@ISA = "Exporter";

[download]

There are other style errors too in the code, like not storing $cipher in an our variable, or at least declaring it; create the $cipher object only once (if the module allows that); either not having the useless new function or converting Encrypt and Decrypt to methods; not using the one-argument bless in the new method; using strict; calling die instead of exit on an error; etc. These are, however, minor errors, and we should probably first help the OP correcting the more serious errors of the code (ie making the code work)

Sorry if this insulted you.

In reply to Re^3: How to call Module by ambrus
in thread How to call Module by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.