So, Ted, you've received lots of feedback on how to improve the code, yet you're thus far silent in both threads as to whether you've accepted the feedback, and if you have accepted the comments, you should probably update the original "snippet" above...

The Critical comments made thus far are, in this case, not personal attacks. Silence from you makes it seem like you're not interested in the feedback you've received.

Simply posting random code without a story as to what the code does, and why someone else might find it valuable means you've relagated such code to the bottom of the dustbin of snippets. You cared enough to post it originally, don't let a few critical comments make you abandon your case, fix it, make it better, make it usable to others, and state why you think it should be used by others.

-Scott


In reply to Re^3: mship.pm by 5mi11er
in thread mship.pm - my first module by tcf03

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.