Besides the performance issue you mentioned, I don't even think that your code works.

You need to fix couple of things:

  1. you need & not |
  2. you need to do an ord()

Test this:

my $c = chr(0xff);
my $sum = 0;
if ($c) {
    (ord($c) & 0x01) && ($sum++); 
    (ord($c) & 0x02) && ($sum++); 
    (ord($c) & 0x04) && ($sum++); 
    (ord($c) & 0x08) && ($sum++); 
    (ord($c) & 0x10) && ($sum++); 
    (ord($c) & 0x20) && ($sum++); 
    (ord($c) & 0x40) && ($sum++); 
    (ord($c) & 0x80) && ($sum++); 
}
print $sum;

[download]

Your code would look like this (there is no need to count the size of the file, I leave it to you to fix the performance)

use strict;
use warnings;

open(FIN,"perl.exe") or die "cant open file\n"; 
my $sum = 0;
my $c;
while (read(FIN, $c, 1)) {
    if ($c) {
        (ord($c) & 0x01) && ($sum++); 
        (ord($c) & 0x02) && ($sum++); 
        (ord($c) & 0x04) && ($sum++); 
        (ord($c) & 0x08) && ($sum++); 
        (ord($c) & 0x10) && ($sum++); 
        (ord($c) & 0x20) && ($sum++); 
        (ord($c) & 0x40) && ($sum++); 
        (ord($c) & 0x80) && ($sum++); 
    }
} 
print "$sum bits are set\n";

[download]

In reply to Re: counting set bits in binary file by pg
in thread counting set bits in binary file by dwhite20899

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.