Is there a better way to do this?

A better way, in my opinion, would be to have the return value of routine indicate whether the for loop should move onto the next value.

foreach $row (@array) {
  next unless routine($row);
  # more code here
}

sub routine {
  if ($row != '10') {
    print "stuff";
    return 1;
  } else {
    return 0;
  }    
}

[download]

A minor issue with your code as posted: You cannot say $row != '10'. You are using numeric equality against a string. The correct technique is to either compare against a number $row != 10 or compare using string equality $row ne '10'.

You can get Perl to help you with looking out for problems like this if you have warnings switched on. To enable them, add a use warnings; somewhere in the file.

• another intruder with the mooring in the heart of the Perl

In reply to Re: next'ing out of a "foreach" loop within a subroutine by grinder
in thread next'ing out of a "foreach" loop within a subroutine by awohld

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.