The error occur because you're are only initializting $a. Try:
my ($a,$c,$g,$t) = (0, 0, 0, 0);
or
my $a = 0;
my $c = 0;
my $g = 0;
my $t = 0;
Notice the lack of quotes around a numerical zero.
Aside from that,
- you have lots of redundancy,
- you use the less readable form of for,
- you use $a which is special, and
- you use four seperate vars ($a,$c,$g,$t) where a hash would be better.
Fix:
sub comNucCount {
my($string1, $string2) = @_;
$string1 = uc $string1;
$string2 = uc $string2;
my %counts = map { $_ => 0 } qw( A C G T );
for my $position (0 .. length($string1)-1) {
my $char = substr($string1,$position,1);
$counts{$char}++
if substr($string2, $position, 1) eq $char;
}
return "A=$counts{A}, C=$counts{C}, G=$counts{G}, T=$counts{T}";
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.