A mixture of, mostly minor, stylistic issues:

use strict; use warnings;

That mantra should come before you do anything else! Always! Regardless of projet size! No exceptions! Comprende?

(condition) or print "fail string";

is cute, but

print "fail string" if condition;

is clearer. In cases where the fail condition is non-zero it is even better to make it explicit:

print "fail string" if 0 != (condition);

It is tempting to comment things that you have just learned, but that can lead to over commenting and make it harder to grok the flow of the code.

$var1 . 'string1' . "string2" is better written as "${var1}string1string2". Note the ${var1} usage to clarify where the variable name ends.

The block for while (<FILE2CHANGE>) { is not indented.


DWIM is Perl's answer to Gödel

In reply to Re: Edit a List of Files by GrandFather
in thread Edit a List of Files by lev36

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.