I guess the answer will end up being 'obvious', but I'm banging my head against the wall here...

I have a simple script which should list all the files in a given directory, then read them one by one, checking for dos format. That list is then printed out. My problem is, after the grep, the @files array ends up containing lines from the files I'm reading, when it originally contains the paths to the files.

I'm guessing this is because (inside the grep )$_ is an alais to the array value, so the file read is automagically smashing this, and making it back into my array.

That would be a pretty bad gotcha, and one I'd be surprised I'd not run across until now. If that's is indeed the case, could someone please suggest an alternative/ways to avoid this?

Anywho, here's the distilled example... 

#!/usr/bin/perl
use strict;
use File::Find;

my $directory = "/tmp/rja/find_test";

my @files = ();
find(sub { $File::Find::name =~ m/${directory}(.*)$/; push @files, $1}
+,  $directory);
@files = grep { is_dos_format("$directory/$_") } @files;

foreach my $file (@files) {
    print "FAILED FILE - $file\n";
}



#==============================================================
sub is_dos_format {
    my $file_path = shift;
    
    open RJA, $file_path or die("Couldn't open file for reading ($file
+_path): $!");
    while (<RJA>) {
        if ($_ =~ m/\r\n/) {
            return 1;
        }
    }
    
    return;
}

[download]
NB: This has a byte size on my PC of 666, make of that what you will :S
---
my name's not Keith, and I'm not reasonable.

In reply to grep and find file weirdness by reasonablekeith

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.