Problems of varying importance:
- use strict; and use warnings; are missing, hidding some errors.
- split is misspelled.
- Most variables are not declared.
- Some sigils are missing.
- $arry_hash contains a reference to a scalar (\$arry_hash) instead of a reference to an array (\@arry_hash) as it should.
- Unsafe 2-arg open is used.
- The file is closed at a different level than the one at which it was opened.
Fixed:
use strict;
use warnings;
use Data::Dumper qw( Dumper );
sub create_array {
my ($fh) = @_;
my @data;
while (<$fh>) {
chomp();
my %record;
for my $field (split ',') {
my ($key, $value) = split /=/, $field;
$record{$key} = $value;
}
push @data, \%record;
}
return \@data;
}
# open(my $infh, '<', $myfile)
# or die("Unable to open data file \"$myfile\": $!\n");
# my $data = create_array($infh);
# close($infh);
my $data = create_array(*DATA);
print(Dumper($data));
__DATA__
A2=ABCD,A3=0123
A2=QWER,A3=4567
A2=ASDF,A3=7890
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.