On my computer, it takes about 2 seconds to run on an array with 1 million ints: 
my @arr = (1 .. 1_000_000);
my $x   = 425983;
printf "search for $x? found at position: %s\n", binarySearch(0,$x,\@a
+rr);

[download]
However, if I go to 5 million, my operating system starts thrashing. Maybe that's what's happening to you too (memory usage starts becoming an issue). It's also quite possible that python has lower overhead for integer scalars than Perl, but I have no idea.

One thing I noticed is that you pass in the array by reference (good idea), but the first thing you do is copy it entirely into a local variable. Why not keep accessing it by reference, like this: (I changed some other things around too) 

sub binarySearch {
  my ($begin, $query, $array) = @_;

  return 0        if $query < $array->[0]        and $begin == 1;
  return $#$array if $query > $array->[$#$array] and $begin == 0;

  my ($left,$right,$prevCenter, $center) = (0, $#$array, -1);

  while(1) {
    $center = int (($left + $right)/2);

    if ($query == $array->[$center]) {
      if ($begin == 1)  {
        $center-- until $center == 0
                     or $array->[$center] != $array->[$center-1];
      } else {
        $center++ until $center == $#$array
                     or $array->[$center] != $array[$center+1];
      }
      return $center;
    }

    if ($center == $prevCenter) {
      return $right   if $begin == 1;
      return $right-1 if $begin == 0;
    }
    $right = $center if $query < $array->[$center];
    $left  = $center if $query > $array->[$center];
    $prevCenter = $center;
  }
}

[download]
This should save a lot of memory. It now takes about 10 seconds running on 5 million ints for me.

blokhead

In reply to Re: My Binary Search Perl code takes forever by blokhead
in thread My Binary Search Perl code takes forever by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.