comment on

In addition to all of the above, I'd suggest taking all of your $line testing and putting it in one procedure. This provides two benefits:

You can define $sql once, at the top, and have a single

     my $statement = $db_handle->prepare($sql)
                    or die "Couldn't prepare query '$sql': $DBI::errst
+r\n";
     $statement->execute()
                    or die "Couldn't execute query '$sql': $DBI::errst
+r\n";
[download]

after the conditionals if you have a non-null $sql.

The general flow of logic will be more evident

In reply to Re: Need Critique (Good or Bad) by apl
in thread Need Critique (Good or Bad) by onegative

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.