I'll give you my impressions while reading it. So don't be surprised if I'm asking questions that get explained later in the slides

In the 'Show Me' slide there's a superfluous 'I'

. Starting with the slide 'Programming API' it was a bit confusing. Because at first I thought version meant version of the program code. Also a lot of "unspecific" sentences like 'do the appropriate thing' 'This does what it says'. Probably that works better when a presenter fills in the blanks.

Why does get_or_create_test_version need a person_id to create a test version?

"It finds the current version". In what way is a version current? Shouldn't there be 2 or more current versions?

"If none is found it chooses a random version... and saves it". Why save that random version. Shouldn't it be already stored in some version pool (otherwise it couldn't be selected. Or does your library *generate* random versions?

My main gripe here seems to be that the programming API is thrown in too early, I would have liked data definitions before API definitions. Then show the API and give an example how it is used to generate a test with two versions and display the test for a specific user. But maybe this is just a sign of my ignorance of the subject of your presentation or a sing of my brain not working

Got to slide 40 where I needed to think a while before I understood what 'changing the mix they get' means. '... while the test is running'. Probably not a problem at the presentation since you will be filling in the blanks

Got no further because I need to work for my day job some more, but hope this helps a little


In reply to Re: Please review my OSCON presentation by jethro
in thread Please review my OSCON presentation by tilly

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.