in reply to Please review my OSCON presentation
In the 'Show Me' slide there's a superfluous 'I'
. Starting with the slide 'Programming API' it was a bit confusing. Because at first I thought version meant version of the program code. Also a lot of "unspecific" sentences like 'do the appropriate thing' 'This does what it says'. Probably that works better when a presenter fills in the blanks.
Why does get_or_create_test_version need a person_id to create a test version?
"It finds the current version". In what way is a version current? Shouldn't there be 2 or more current versions?
"If none is found it chooses a random version... and saves it". Why save that random version. Shouldn't it be already stored in some version pool (otherwise it couldn't be selected. Or does your library *generate* random versions?
My main gripe here seems to be that the programming API is thrown in too early, I would have liked data definitions before API definitions. Then show the API and give an example how it is used to generate a test with two versions and display the test for a specific user. But maybe this is just a sign of my ignorance of the subject of your presentation or a sing of my brain not working
Got to slide 40 where I needed to think a while before I understood what 'changing the mix they get' means. '... while the test is running'. Probably not a problem at the presentation since you will be filling in the blanks
Got no further because I need to work for my day job some more, but hope this helps a little
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re^2: Please review my OSCON presentation
by tilly (Archbishop) on Jul 16, 2008 at 21:19 UTC | |
by jethro (Monsignor) on Jul 17, 2008 at 17:28 UTC | |
by tilly (Archbishop) on Jul 17, 2008 at 21:20 UTC | |
by jarich (Curate) on Jul 25, 2008 at 04:14 UTC | |
by tilly (Archbishop) on Jul 25, 2008 at 05:03 UTC | |
by jethro (Monsignor) on Jul 18, 2008 at 14:08 UTC | |
by tilly (Archbishop) on Jul 18, 2008 at 16:55 UTC | |
|