1) I'm sure others have told you but with your file read inside the loop that checks for each name, you end up reading each file once for every name checked. That's an inefficiency. The file loop should be the outer loop.

One way of doing this is:

my @name_array = qw(fred joe john frank );
for my $file(@file) {
    open(FILE, "<", $file) 
        or die("can't open file $file.\n");
    while (my $line = <FILE>) {
        my $match = grep { $line =~ /$_/i } @name_array; 
        print OUT $line if ( $match );
    }
}

[download]
2) Since the "printing" loop doesn't check to see if the line has been printed before, you can print similar text over and over. If you want to avoid that, use a hash to ensure uniqueness of the lines being printed.

An example:

my %unique;
if ( $have_a_line_to_print ) {
    $unique{$have_a_line_to_print} = 1;
}
#
# much later
#
for( sort keys %unique ) {
    print;
}

[download]

In reply to Re: Nested foreach problem by dwm042
in thread Nested foreach problem by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.