comment on

A couple of things I noticed here:

On my box, /var/run is root.root 0755. This means that writing the pid file should fail for regular users, but it doesn't. A small change to the code allows the detection of the error:
```
return IO::File->new($file, O_WRONLY|O_CREAT|O_EXCL,0644)
  || die "Can't create $file: $!\n";
[download]
```
Because of or's low precedence, the return statement is evaluated before Perl can check the value returned by IO::File->new. Using || instead allows the check to take place.

This line causes a complaint about an insecure dependency:

die "Server already running with PID $pid" if kill 0 => $pid;
[download]

Insert this code directly above it to untaint $pid:

if ($pid =~ /^(\d+)$/) {
  $pid = $1;
} else {
  die "funky pid read from $file!";
}
[download]

In reply to Re: Daemon sub refuses to daemonize. Why? by converter
in thread Daemon sub refuses to daemonize. Why? by BMaximus

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		`&`
	<		`<`
	>		`>`
	[		`[`
	]		`]`

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.