You can use the perlcritic tool to automatically check your code for best practices. It will point out some tips such as: 
Useless interpolation of literal string at line 22, column 13.
Bareword file handle opened at line 26, column 1.
Glob written as <...> at line 36, column 10.  See page 167 of PBP.
Readline inside "for" loop at line 36, column 10.  See page 211 of PBP
+.

[download]

You can also convert your comments to POD and get a manpage for free: 

=head1

PURPOSE: Create an mksysb of servers listed in $path\mksysb.conf.
          Also, purge all mksysb's that are over an age set by the 
          filemaxage parameter.  

=cut

[download]

... then from the command line: 

perldoc mksysb.pl

[download]

In reply to Re: check my code by toolic
in thread check my code by TechFly

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.