Once again, I strongly recommend you move the object constructor outside the while loop. Tux, a.k.a. H. Merijn Brand, the author of Text::CSV_XS, which is the base module you're indirectly using, amplified this suggestion in his reply to your post. He explained that "you create a new csv parsing object for every line read." You really don't want to do this needlessly for 1.7 million records. And Tux's advice to use getline instead of <>/parse/fields is a wise one.

I think you're trying too hard to handle the floating-point weight values. Just be explicit with your tests:

if ($pounds == 0.0 and $grams == 0.0) {
    ...
}

[download]

The right coercions happen automagically. Here's the proof:

D:\>perl -E "say '' == 0.0 ? 'Equals' : 'Does not equal'"
Equals

D:\>perl -E "say '0' == 0.0 ? 'Equals' : 'Does not equal'"
Equals

D:\>perl -E "say '0.0' == 0.0 ? 'Equals' : 'Does not equal'"
Equals

D:\>perl -E "say '123' == 0.0 ? 'Equals' : 'Does not equal'"
Does not equal

D:\>perl -E "say '123.4' == 0.0 ? 'Equals' : 'Does not equal'"
Does not equal

D:\>

[download]

So you didn't like any of the other improvements I suggested in my refactored version of your script?

Jim

In reply to Re^4: problems parsing CSV by Jim
in thread problems parsing CSV by helenwoodson

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.