Well, sure, if you turn off warnings, naturally you get no warnings, but you are ignoring things that hint at problems with your code. By removing strict, you get fewer errors, but you also get no information when you mistype variable names. Do you think a script works better if it shows no error message but simple prints the wrong result? This is how politicans solve problems, by removing the warning signs ;-)

You still haven't changed $element1 to @element1 in this script. Did you notice that you call your subroutine as "decko" in line 21?

Another problem: you should not use foreach on an array when you change the array inside with pop,shift and push. Normally it leads to fewer loop executions as expected. In your case it is even fortunate that it does so because if it had run for every element in the array, your array would have only 1 or 2 cards left because you are constantly dropping cards (i.e. removing them from the array) with your broken shuffle

Look at the script I posted to your first post about this problem in Re: Perl Subroutine. Notice that I used a different loop. I did it because foreach is not the right choice here


In reply to Re^3: Perl subroutine update by jethro
in thread Perl subroutine update by craziestfire73

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.