A better way to do it is collect what you need first, then do the comparison, that is:
- Make a hash
- For each element in each list, add the list # to the hash for that element if not already on there
- For each key of the hash, if the list has more than 1 item, it's duplicated.
Programmically, it would look like:
my %hash;
foreach my $i ( 0..$#array ) {
foreach my $j ( @{ $array[ $i ] } ) {
$hash{ $j } ||= []; #need to set this if not made
if ( ! grep { $i == $_ } @{ $hash{ $j } } ) {
push @{ $hash{ $j } }, $i;
}
}
}
my @matches = grep { @{ $hash{ $_ } } > 1 } keys %hash;
This is probably close to being on the order of N^2 (N being the total number of elements in the entire 2d structure), but will be closer to N as the number of possible duplicates drop.
Note that if you wish to exclude elements, you can simply add an "if (something) next" line in the deepest block, or do an additional grep on the @{ $array } in the second foreach block to remove elements you don't care about. But it's probably faster to look at everything, then drop what you don't need then checking every time.
Dr. Michael K. Neylon - mneylon-pm@masemware.com
||
"You've left the lens cap of your mind on again, Pinky" - The Brain
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.