If you look in the documentation for readdir you will see:

If you're planning to filetest the return values out of a readdir, you'd better prepend the directory in question. Otherwise, because we didn't chdir there, it would have been testing the wrong file.

So if you change your code as follows, it will work:

$dirname = "C:/Perl/Test/"; opendir(DIR,$dirname); @file1 = readdir(DIR); foreach $file1(@file1) { if (-f "$dirname$file1") { print("$file1\n"); } }

Since you're new to Perl, it's the perfect time to learn how to program with 'use strict' in mind. Try this:

use strict; use warnings; use autodie; my $dirname = "C:/Perl/Test/"; opendir my( $dir_handle ), $dirname; my @file1 = readdir $dir_handle; foreach my $file1 ( @file1 ) { if ( -f "$dirname$file1" ) { print "$file1\n"; } }

This is a good time to introduce grep, which can make looping tests that result in a list much simpler.

use feature qw/ say /; use strict; use warnings; use autodie; my $dirname = "C:/Perl/Test/"; opendir my( $dir_handle ), $dirname; my @files = grep { -f "$dirname$_" } readdir $dir_handle; say for @files;

say is a feature of Perl starting with 5.10. It basically just adds a "\n" to every call. my is explained best in perlsub.


Dave


In reply to Re: Why is "If" condition not working by davido
in thread Why is "If" condition not working by somya99

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.