Readability (which often is eq 'maintainability.'

• Be generous with whitespace; Perl doesn't charge by the " " ( nor by the \t )
• Indentation -- find a style YOU like and use it... for example:
  

  if ( !-e $xmlpath ) { 
      if ( !-e $outpath ) {
          $data=
      }
  }
  [download]

• Global declaration of all vars (see Re: code for review ) above... and, style-wise,
  my ($aff_print, $aff_print1, $outpath,  $data ....);
• else {}}else {} Huhn?

Update: And, if -- as it appears from the comments above -- you have edited your post without notice, DON'T.

Use strikeouts rather than removing or editing text or code; mark additions and insertions for what they are. Editing without acknowledgement destroys original context and can make posts by others appear senseless or inexplicable.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.