I see a few minor problems. First require 5.6.0 is not a good idea. You probably want something like use 5.006 instead. The require should execute after the use warnings, not what you want. Also the ability to use 1.2.3 type version strings was not avialable till perl version 5.6.0. You might want to consider even trying to make your module work on perl 5.005.

As for your hardware_info function, I think you could improve it by caching the hardware info, only computing it once, rather then recomputing the same info three times if someone calls model_type, processor_arch, and processor_speed in succession.

I wonder if you really want to call your module AIX::SysInfo, or similar.

As for your export list, it's not a good idea to export so much by default. Try to limit or eliminate your default export list. You also have declared an export tag which does nothing. Best to get rid of it if its going to do nothing. </p.

Additionally, Sys::Hostname already exists and is standard. Your hostname function is not worth much.

If you want to be paranoid, you should be checking the return values of the various programs you are calling after the close of their pipes, in case something goes horribly wrong, and maybe checking if something goes wrong with your backticks.

In reply to Re: please review my first module by wog
in thread please review my first module by blueflashlight

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.