in reply to please review my first module
As for your hardware_info function, I think you could improve it by caching the hardware info, only computing it once, rather then recomputing the same info three times if someone calls model_type, processor_arch, and processor_speed in succession.
I wonder if you really want to call your module AIX::SysInfo, or similar.
As for your export list, it's not a good idea to export so much by default. Try to limit or eliminate your default export list. You also have declared an export tag which does nothing. Best to get rid of it if its going to do nothing. </p.
Additionally, Sys::Hostname already exists and is standard. Your hostname function is not worth much.
If you want to be paranoid, you should be checking the return values of the various programs you are calling after the close of their pipes, in case something goes horribly wrong, and maybe checking if something goes wrong with your backticks.
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re: Re: please review my first module
by blueflashlight (Pilgrim) on Jul 02, 2001 at 09:23 UTC |