in reply to Re: please review my first module
in thread please review my first module

Thanks for the hints! I've taken some of your advice, and I've got a few questions/comments on your other points.

I've changed the module so that it now runs on several older versions; the oldest I've got installed anywhere is 5.001, and it's got a problem there, but its fine now on 003 and 005.

I've also gotten rid of the "%EXPORT_TAGS" and "@EXPORT_OK" vars, as they were empty. I'm not clear on how I would reduce the number of items exported, since I want to provide access to the functions that I am exporting.

I plan on keeping the 'hostname' function in there, cause I thought people would like to have that function available without having to load another module. It adds very little overhead (as far as I can tell.)

Thanks for the suggestions! -s-