This works for me:

#!/usr/bin/perl
use warnings;
use strict;

open my $TEMPLATE, '<', 'rtr-template.txt' or die "Template: $!";
my @template = <$TEMPLATE>;

while (<>) {
    chomp;
    my ($location, $name, $lo0ip, $frameip, $framedlci, $eth0ip)
        = split (/,/);

    my $ofile_name = $name . ".txt";
    open my $OUT, '>',  $ofile_name or die "Output: $!";

    for my $line (@template) {
        $_ = $line;
        s/##location##/$location/;
        s/##rtrname##/$name/;
        s/##eth0-ip##/$eth0ip/;
        s/##loop0-ip##/$lo0ip/;
        s/##frame-ip##/$frameip/;
        s/##frame-DLCI##/$framedlci/;
        print {$OUT} $_;
   }
}
[download]

The important changes I made to your code:

• 3-argument version of open is used.
• Lexical filehandles are used ($FH instead of FH).
• I am using strict.
• The template file is not changing, so it is opened and read just once.
• chomp is used to remove the newline from $eth0ip.
• print is used instead of printf: using printf without a format string is useless.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.