in reply to Re: Can you spot the problem?
in thread Can you spot the problem?

Works if you change the all the |s to &s. (Plus you can omit the parens if you're golfing, since junctions now bind tighter than comparisons. Well, okay, you can omit the parens even if you're not golfing.)

Replies are listed 'Best First'.
Re: Re: Re: Can you spot the problem?
by ambrus (Abbot) on Mar 05, 2004 at 19:57 UTC

    I'd rather leave the |'s and change the comparison from "if ... <256" to "unless ... >255". That way the puzzle still works in perl5.

[reply]
      I like making it all into one logical return expression, with no conditionals.

      Without the two character fix/spoiler: 

      sub isValidIP {
   return (shift =~ m/^(\d+)\.(\d+)\.(\d+)\.(\d+)$/ and (($1|$2|$3|$4)
+ < 256));
}

      [download]
      Update: I wasn't offering a Perl 6 solution, despite the subthread my response was in. That would be 
         return (shift =~ m/^(\d+)\.(\d+)\.(\d+)\.(\d+)$/ and not (($1|$2|$3
+|$4) > 255));

      [download]
      The PerlMonk tr/// Advocate
[reply]
[d/l]
[select]
[reply]

In Section Meditations