New Moderation/Approval code (testers wanted)

Hi all,
Time to get some of this approval/moderation stuff tested by people other than me..

In case you don't have a clue what I'm on about, tye started some changes to the Approval system a while back, which mostly involve internal changes, namely getting rid of using the link table to 'link' nodes to sections and/or the frontpage. (tye, feel free to add anything/correct me). I've picked this up and have been adjusting/adding to/improving it (hopefully) to a point where we can start using it in production.

I'm inviting anyone with a login on the test server to have a look, and test out the functionality. In theory, the overall result should work as before, on the surface. What needs testing:

Moderation Nodelet - replaces the Approval Nodelet, also the 'removelinks' part of the editors nodelet
Node Status - nodelet, check that it reflects the correct status
The Monastery Gates - should show nodes frontpages by the moderation nodelet
Seekers of Perl Wisdom - and other sections, show approved nodes (or all if showunapproved is on), approve nodes if level > 5

Changes in detail:

moderation nodelet - make work, mostly
node status - nodelet, use isapprove
newapprove - make work, adapt
isapprove - ..
approvalhistory - table that holds the history of all approval actions
approvalstatus - table that holds the current/last status of each approved/fp'd node (no entry means unapproved)
newcachedlistapproved - complete rewrite of cachedlistapproved, to use new tables etc
Monastery Gates/Section pages - use newcachedlistapproved
moderatelist default outer container - use newapprove opcode
cachedinfo table - made key unique
listapproved settings - added daysOnFrontPage, updateInterval

Some of the section pages are not yet converted, and the approve code is still producing entries in the link table. These will be fixed soon.

I'd appreciate if people would point out any other areas that are using the 'listapproved'/'approval' type code, that I've otherwise missed. (I've already noted that several section-similar pages, such as Editor Requests, SQL Query list, need another htmlcode, which doesnt use approval (since their entries arent/cant be approved.)

Many thanks to tye for starting this in the first place.

PS: Note that this is by no means the end of the changes coming, once this has proven itself, I'll get on to the showing of history, and similar for considerations..

Comment on New Moderation/Approval code (testers wanted)

Replies are listed 'Best First'.
Re: New Moderation/Approval code (testers wanted) by ysth (Canon) on Oct 21, 2004 at 19:57 UTC
Shouldn't moderatelist default outer container use post, not get? And is there a reason to not use openform?	[reply]
Re: New Moderation/Approval code (testers wanted) by ysth (Canon) on Nov 23, 2004 at 20:28 UTC
Moved a change I made to Approval Nodelet to the test server's Moderation Nodelet (and also fixed a or/\|\| bug); copied the Moderation Nodelet (both before and after my change) over here.	[reply]
Re: New Moderation/Approval code (testers wanted) by ysth (Canon) on Nov 23, 2004 at 22:58 UTC
Update: all is better; consider now works. Update: there is an op=consider, I'm just being lied to by the CGI::param nodelet, and consider needs to understand the new cv\d+ params. The strange thing is that I thought this was working a few weeks ago. I'm working on this now (and have a patch to fix CGI::param :) Hmm, the Moderation Nodelet doesn't seem to use op=consider at all, so votes on considerations aren't working. Was the plan to merge approve and consider opcodes? Am I missing something? To expand, looking at http://pmdev.flux8.com:8081/?node_id=324257, the nodelet looks like (viewed as a god): <form method="post" action="?" enctype="application/x-www-form-u +rlencoded"> <input type="hidden" name="node_id" value="324257"> <input type="hidden" name="linktype" value="433" /> <input type="hidden" name="sectionid" value="479" /> <input type="hidden" name="op" value="newapprove" /> <input type="hidden" name="origtype" value="perlquestion" /> <input type="radio" name="324257" value="move" />Move <input typ +e="radio" name="324257" value="fp" />Front-Page <input type="radio" n +ame="324257" value="ok" />Approve <input type="radio" name="324257" v +alue="noop" checked />nada<br /> Move to: <select name="movetotype"> <option selected value="perlquestion">Seekers of Perl Wisdom</option> <option value="perlmeditation">Meditations</option> <option value="monkdiscuss">Perl Monks Discussion</option> <option value="perlcraft">Perl Craft</option> <option value="obfuscated">Obfuscated Code</option> <option value="poem">Perl Poetry</option> <option value="CUFP">Cool Uses For Perl</option> <option value="perlnews">Perl News</option> <option value="perltutorial">Tutorials (no rush)</option> </select> <br /> <a HREF="/index.pl?node_id=28877">Considered</a>: [<a hre +f="/index.pl?node=ysth">ysth</a>] off with her head<hr /> Keep/Edit/Delete: 3/0/5<br /> <input type="hidden" name="op" value="consider" /><input t +ype="radio" name="cv324257" value="keep" />keep <input type="radio" n +ame="cv324257" value="edit" />edit <input type="radio" name="cv324257 +" value="delete" />delete <input type="radio" name="cv324257" value=" +unconsider" />unconsider <input type="radio" name="cv324257" value="n +ovote" checked />novote<hr /> <input type="submit" name="sexisgood" value="moderate" /> <a HREF="/index.pl?node_id=17645">help</a> </form> [download] And selecting keep and hitting the button sends this: `node_id=324257 linktype=433 sectionid=479 op=newapprove origtype=perlquestion 324257=noop movetotype=perlquestion cv324257=keep sexisgood=moderate` [download] But I don't see anything in newapprove to handle cv<nid>=keep.	[reply] [d/l] [select]