in reply to New Moderation/Approval code (testers wanted)

Update: all is better; consider now works.

Update: there is an op=consider, I'm just being lied to by the CGI::param nodelet, and consider needs to understand the new cv\d+ params. The strange thing is that I thought this was working a few weeks ago. I'm working on this now (and have a patch to fix CGI::param :)

Hmm, the Moderation Nodelet doesn't seem to use op=consider at all, so votes on considerations aren't working. Was the plan to merge approve and consider opcodes? Am I missing something?

To expand, looking at http://pmdev.flux8.com:8081/?node_id=324257, the nodelet looks like (viewed as a god):

<form method="post" action="?" enctype="application/x-www-form-u +rlencoded"> <input type="hidden" name="node_id" value="324257"> <input type="hidden" name="linktype" value="433" /> <input type="hidden" name="sectionid" value="479" /> <input type="hidden" name="op" value="newapprove" /> <input type="hidden" name="origtype" value="perlquestion" /> <input type="radio" name="324257" value="move" />Move <input typ +e="radio" name="324257" value="fp" />Front-Page <input type="radio" n +ame="324257" value="ok" />Approve <input type="radio" name="324257" v +alue="noop" checked />nada<br /> Move to: <select name="movetotype"> <option selected value="perlquestion">Seekers of Perl Wisdom</option> <option value="perlmeditation">Meditations</option> <option value="monkdiscuss">Perl Monks Discussion</option> <option value="perlcraft">Perl Craft</option> <option value="obfuscated">Obfuscated Code</option> <option value="poem">Perl Poetry</option> <option value="CUFP">Cool Uses For Perl</option> <option value="perlnews">Perl News</option> <option value="perltutorial">Tutorials (no rush)</option> </select> <br /> <a HREF="/index.pl?node_id=28877">Considered</a>: &#91;<a hre +f="/index.pl?node=ysth">ysth</a>&#93; off with her head<hr /> Keep/Edit/Delete: 3/0/5<br /> <input type="hidden" name="op" value="consider" /><input t +ype="radio" name="cv324257" value="keep" />keep <input type="radio" n +ame="cv324257" value="edit" />edit <input type="radio" name="cv324257 +" value="delete" />delete <input type="radio" name="cv324257" value=" +unconsider" />unconsider <input type="radio" name="cv324257" value="n +ovote" checked />novote<hr /> <input type="submit" name="sexisgood" value="moderate" /> <a HREF="/index.pl?node_id=17645">help</a> </form>
And selecting keep and hitting the button sends this:
node_id=324257 linktype=433 sectionid=479 op=newapprove origtype=perlquestion 324257=noop movetotype=perlquestion cv324257=keep sexisgood=moderate
But I don't see anything in newapprove to handle cv<nid>=keep.