Well, for one thing { } is the anonymous hashref constructor and you'd get an odd-number-of-elements-in-hash-assignement warning. And for another you left off use List::Util qw( shuffle ).