Re^3: Todo list should additional levels be added (--once and for all)

Once and for all is a good idea, but doesn't interface well with what free time/interest I have to do certain changes. I've created a patch for getLevel as tye suggested. If it gets applied I would like to go ahead and remove all the hardcoded 11's from code that calls getLevel and isGod. This should make it somewhat easier for you to sweep through and decide which getLevel calls are to determine permissions and which are just level stuff. But I see no need to wait and do everything all at once.

I would like to see your permissions changes implemented though.

Comment on Re^3: Todo list should additional levels be added (--once and for all)

Replies are listed 'Best First'.
Re^4: Todo list should additional levels be added (once and for all) by demerphq (Chancellor) on Oct 28, 2004 at 08:24 UTC
Ah, ok let me clarify myself here. The proposed changes I have in mind would still benefit from your patch. My comment was purely on a conceptual/design level. Since isApproved rules will still have to call getLevel() (but through a clean interface) enhancements to getLevel are probably required. All my point was that instead of being hasty and just cutting the new levels in lets be slower and more methodical and get to a better solution. I mean we can wait a while before adding the new levels right? Anyway :-) --- demerphq _{First they ignore you, then they laugh at you, then they fight you, then you win. -- Gandhi Flux8}	[reply]
Re^5: Todo list should additional levels be added (once and for all) by ysth (Canon) on Oct 28, 2004 at 08:34 UTC
Sorry to vent at you like that; I was in a bad mood (nothing to do with perlmonks) and shouldn't have posted. There's a middling amount of preparatory stuff that's worth doing even if the levels never do change, and the getLevel stuff is one item of that.	[reply]
Re^6: Todo list should additional levels be added (once and for all) by demerphq (Chancellor) on Oct 28, 2004 at 08:38 UTC
No worries and I totally agree. --- demerphq _{First they ignore you, then they laugh at you, then they fight you, then you win. -- Gandhi Flux8}	[reply]