JP Sama has asked for the wisdom of the Perl Monks concerning the following question:

Dear PerlMonks,

I'm having troubles with a CGI to upload images to my site, I've tried lots of ways to solve it... but none worked!
the code i'm using is something like that: 
#!/usr/bin/perl

use    CGI;
use    CGI::Carp 'fatalsToBrowser';
CGI::ReadParse(*in);

my $homeurl    = 'http://joao.warp.psi.br';
my $imagedir = '/www/joao/images';

my ($s,$m,$h,$mday,$mon,$year,$w,$y) = gmtime(time);

my $id = $year.$mon.$mday;

# save thumbnail
my $thumb = &FileUpload($in{iddt});
open(MAKETHUMB,">$imagedir/$idt.gif")
    or die("Could not save $idt.gif");
print MAKETHUMB $thumb;
close(MAKETHUMB);

# save image 'idd'
my $img = &FileUpload($in{idd});
open(MAKE,">$imagedir/$id.gif")
    or die("Could not save $id.gif");
print MAKE $img;
close(MAKE);

# the images are mine!
my @files = glob("$id*.gif");
chown 'joao','fodas',@files;


# upload file (used    here to    upload images)
sub    FileUpload {

    my ($formfield)    = shift;
    my ($filename,$filesize,$filedata);

    # load query handle
    $query = $in{CGI};

    if ($filename =    $query->param($formfield)) {
        my $tmp    = $/;
        undef($/);
        $filedata =    <$filename>;
        $filesize =    length($filedata);
        $/ = $tmp;
    }

    # find what    the    trails look    like and get the
    # true file    name without the garbage
    if ($filename =~ m/[\\\/\:]/gi)    {
        $filename =~ s/[\\\/\:]/\//g;
        my @tmp    = split(/\//,$filename);
        $filename =    pop(@tmp);
    }

    return($filedata);
}

[download]
well, with this i've got the following:
  1. the thumbnail file is not created;
  2. The second image is created but nothing is printed, the image remains with 0k, and is owned by wwwrun;
Because of that, i ask:
why were my images not uploaded?
and why my 'chown' is not working properly?

Can anyone help me? please!
Thank you!!

PS: Oh, and i'm using 'enctype="multipart/formdata"' in my form... and the fields are with the correct names...

#!/jpsama/bin/perl -w
$tks = `mount`;
$jpsama = $! if $!;
print $jpsama;

Replies are listed 'Best First'.
Re: Problems with 'image upload'
by Fastolfe (Vicar) on Nov 07, 2000 at 18:45 UTC
    Please read the CGI documentation, specifically, the section devoted to file upload processing. It has examples. Basically you're doing this wrong: 
    my $img = &FileUpload($in{idd});
open(MAKE,">$imagedir/$id.gif")
    or die("Could not save $id.gif");
print MAKE $img;
close(MAKE);

    [download]
    Should be something like this: 
    my $img = &FileUpload($in{idd});
open(MAKE,">$imagedir/$id.gif")
    or die("Could not save $id.gif");
binmode MAKE;
print MAKE while <$img>;
close(MAKE);

    [download]
[reply]
[d/l]
[select]
Re: Problems with 'image upload'
by Trimbach (Curate) on Nov 07, 2000 at 17:53 UTC
    Your main problem is that you should use the file upload fieldname as a filehandle directly instead of trying to copy it into another variable. Don't try $filename =    $query->param($formfield) but rather $input = <param($formfield)> The documention on CGI.pm goes into this in some detail.

    Better yet, check out the copious examples of file uploading code found elsewhere in the site, such as (Ovid) Re: File Upload To Selected Directory (it doesn't matter that the example doesn't happen to be an image.)

    Gary Blackburn
    Trained Killer

[reply]
[d/l]
[select]
Re: Problems with 'image upload'
by kilinrax (Deacon) on Nov 07, 2000 at 17:10 UTC
    The UID and GID passed to chown should be numerical.

    (Try 'echo $UID' at a shell prompt if you don't know what your numeric user id is.)
[reply]
Re: Problems with 'image upload'
by cianoz (Friar) on Nov 07, 2000 at 19:34 UTC
    remember to put <FORM METHOD="POST"  ENCTYPE="multipart/form-data"> on the form where you place the file upload field
[reply]
[d/l]
      geez! Thank you! After "years" trying... I finally made it...!
      thanks to your hint..
      Explaining:

      My f@#$@% FORM was:
      <FORM METHOD="POST" ENCTYPE="multipart/formdata">

      [download]

      note the formdata part!

      Well... Thank you cianoz!!
      And thank to you all!
      #!/jpsama/bin/perl -w
$tks = `mount`;
$jpsama = $! if $!;
print $jpsama;
[reply]
[d/l]

Back to Seekers of Perl Wisdom