print "Enter the month and day (ex:0605)\n";
$date = <stdin>;
chomp($date);

move(c:/atmcaf00,K:/atm/atmcaf00$date);
move(c:/atmcaf00,K:/atm/atmcaf01$date);
move(c:/atmcaf00,K:/atm/atmcaf12$date);
move(c:/atmcaf00,K:/atm/atmcmf01$date);
move(c:/atmcaf00,K:/atm/atmcmf12$date);

print "All the ATM files have been renamed and move to the ATM folder\
+n";

$wait = <stdin>;
[download]

What I'm referring to is changing this code (extra blank lines removed for space considerations):

sub moving {
    print "Moving $_ to the K:/ATM \n";
    move("$old$_","$new$_$date");
    print "$_ has been moved to the K:/ATM\n";
    print "---------------------------------------------\n";
}

foreach (@files) {
    &moving;
}
[download]

into something more like:

foreach (@files) {
    print "Moving $_ to the K:/ATM \n";
    move("$old$_","$new$_$date");
    print "$_ has been moved to the K:/ATM\n";
    print "---------------------------------------------\n";
}
[download]

Personally I'd also use a named variable instead of $_, though, so I'd write something more like:

foreach my $file (@files) {
    print "Moving $file to the K:/ATM \n";
    move("$old$file","$new$file$date");
    print "$file has been moved to the K:/ATM\n";
    print "---------------------------------------------\n";
}
[download]

But changing $_ to a named variable is not a functional change -- just makes the use of the loop variable a bit more clear.

I've copied the program, created test files & directories, and moved files successfully under a Unix system using this program.

I would suggest stepping through the program with a debugger or adding a print join " ", @files; print "\n"; at the end of your loop to find if your @files array is getting munged somehow. That is where my first guess at the problem would be.

My second guess would involve permission issues and or failure of the move as suggested by others.

And my final guess would involve issues with your installation of perl under windows...

My working test code

Read more... (1027 Bytes)

-Scott