in reply to How to monitor a file located on the remote host(win2k)?

Nine things caught my eye in the 10s I spent looking at your node:

1)
$script_name[((scalar(@script_name)) - 1)]
can be shortened to
$script_name[@script_name - 1]
and
$script_name[$#script_name]
and
$script_name[-1]

2) Why use an array for script_name? The following will do:
my $script_name = (split m!\\!, $0)[-1];

3) Windows also accepts "/" as a path seperator. Fix:
my $script_name = (split m![\\/]!, $0)[-1];
or better yet, the portable
use File::Spec;
my $script_name = (File::Spec->splitpath($0))[2];

4) You use prototypes. Prototypes are discouraged; they should only be used when they are necessary.

4)a) They are not necessary for WMIMain. You're even using the wrong prototype. The following will not work:

WMIMain(@ARGV); sub WMIMain(\@) { my $computer = $_[0]; my $action = $_[1]; my $rvalue = $_[2]; my $kvalue = $_[3]; ...

4) b) You are using prototypes on methods. They are not definitely not necessary there either, since prototypes don't even work (are ignored) when functions are called as methods.

5) You're using user-provided, unvalidated, unescaped value ($kvalue and others) in a SQL commands.

6) I think
scalar(Win32::OLE::in($computers))
should be
scalar(@{Win32::OLE::in($computers)})

7)
scalar(@{Win32::OLE::in($computers)}) lt "1"
won't do what you expect. Use
scalar(@{Win32::OLE::in($computers)}) < 1
or just
@{Win32::OLE::in($computers)} < 1

Same for eq "1" (== 1) and gt "1" (> 1).

Use eq/ne/lt/gt for string comparisons. Use ==/!=/</> for numerical comparisons. This is documented in perlop.

8)
Win32::OLE::in($computers)
can be simplified to
in $computers
if you do
use Win32::OLE qw( in );
at the top.

Update: I spent another 10s looking at the code, and documented the additional problems I found. It seems you have problems with Perl, not just WMI. Do you have a specific question you'd like to have answered?

Replies are listed 'Best First'.
Re^2: How to monitor a file located on the remote host(win2k)?
by ioiioi (Initiate) on Sep 16, 2005 at 02:18 UTC
    Thanks for your help. Acturally, this script work fine for me, what I concentrated about is using which WMI class and how to write the query code? as the following:
    my $computers = $wmi->ExecQuery("SELECT $properties FROM $Win32_Class" +);
    for example, I would like to get the filesize of a file located on the remote host(OS:win2k, IP:192.168.100.22), and the full directory is "D:\poller.php". Any idea? anyway thanks ikegami. ;-)
      hey guys, I have found the following vbs scripts from Microsoft, it can do the job, and I would like to convert it to perl. Is there anybody can help me?
      strComputer = "192.168.100.17" Set objWMIService = GetObject("winmgmts:" _ & "{impersonationLevel=impersonate}!\\" _ & strComputer & "\root\cimv2") Set colFiles = objWMIService. _ ExecQuery("Select * from CIM_DataFile where Name = 'D:\\languardns +s6.exe'") For Each objFile in colFiles Wscript.Echo "File Name: " & "." & objFile.Extension Wscript.Echo "Path: " & objFile.Path & objFile.Name Wscript.Echo "File Size: " & objFile.FileSize Next
        You may ask at the Help Desk section of the monastery... Seriously, you should really take into account the extremely good advices and comments in ikegami's reply.