in reply to How to monitor a file located on the remote host(win2k)?
Nine things caught my eye in the 10s I spent looking at your node:
1)
$script_name[((scalar(@script_name)) - 1)]
can be shortened to
$script_name[@script_name - 1]
and
$script_name[$#script_name]
and
$script_name[-1]
2) Why use an array for script_name? The following will do:
my $script_name = (split m!\\!, $0)[-1];
3) Windows also accepts "/" as a path seperator. Fix:
my $script_name = (split m![\\/]!, $0)[-1];
or better yet, the portable
use File::Spec;
my $script_name = (File::Spec->splitpath($0))[2];
4) You use prototypes. Prototypes are discouraged; they should only be used when they are necessary.
4)a) They are not necessary for WMIMain. You're even using the wrong prototype. The following will not work:
WMIMain(@ARGV); sub WMIMain(\@) { my $computer = $_[0]; my $action = $_[1]; my $rvalue = $_[2]; my $kvalue = $_[3]; ...
4) b) You are using prototypes on methods. They are not definitely not necessary there either, since prototypes don't even work (are ignored) when functions are called as methods.
5) You're using user-provided, unvalidated, unescaped value ($kvalue and others) in a SQL commands.
6) I think
scalar(Win32::OLE::in($computers))
should be
scalar(@{Win32::OLE::in($computers)})
7)
scalar(@{Win32::OLE::in($computers)}) lt "1"
won't do what you expect. Use
scalar(@{Win32::OLE::in($computers)}) < 1
or just
@{Win32::OLE::in($computers)} < 1
Same for eq "1" (== 1) and gt "1" (> 1).
Use eq/ne/lt/gt for string comparisons. Use ==/!=/</> for numerical comparisons. This is documented in perlop.
8)
Win32::OLE::in($computers)
can be simplified to
in $computers
if you do
use Win32::OLE qw( in );
at the top.
Update: I spent another 10s looking at the code, and documented the additional problems I found. It seems you have problems with Perl, not just WMI. Do you have a specific question you'd like to have answered?
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re^2: How to monitor a file located on the remote host(win2k)?
by ioiioi (Initiate) on Sep 16, 2005 at 02:18 UTC | |
by ioiioi (Initiate) on Sep 16, 2005 at 11:25 UTC | |
by blazar (Canon) on Sep 19, 2005 at 14:39 UTC |