Re^2: Proposed new behaviour of isGods and isApproved (per session cache) (update deployed)

This is now merged into my changes and is live on 'production'. Please grab a copy (Everything/NodeBase.pm) for the test server and let me know if you hate any of my changes.

I used the %HTMLVARS differently so all isApproved stuff is under the {isApproved} key so custom failure report code should use $HTMLVARS{isApproved}{last}. I only put node IDs not node hashes in, so dumping it is easy to read.

Thanks.

- tye

Comment on Re^2: Proposed new behaviour of isGods and isApproved (per session cache) (update deployed)

Replies are listed 'Best First'.
Re^3: Proposed new behaviour of isGods and isApproved (per session cache) (update deployed) by demerphq (Chancellor) on Sep 18, 2005 at 11:46 UTC
It looks ok. The only problem is when you simplified the isGod() code you used '=' and not '\|\|=' in line 2191 so its resetting its state every time. I changed it from `$vars= $vars->{isGod}= {};` [download] to `$vars= ( $vars->{isGod} \|\|= {} );` [download] and it seems to be fine. The isApproved stuff OTOH appears to be problem free. Thanks for applying the patches. :-) --- $world=~s/war/peace/g	[reply] [d/l] [select]
Re^4: Proposed new behaviour of isGods and isApproved (per session cache) (fix deployed) by tye (Sage) on Sep 18, 2005 at 15:38 UTC
Thanks. I've put that fix into production. These changes should kick up the site efficiency a notch. Good work, demerphq. - tye	[reply]