in reply to Re^2: Proposed new behaviour of isGods and isApproved (per session cache) (update deployed)
in thread Proposed new behaviour of isGods and isApproved (per session cache)

It looks ok. The only problem is when you simplified the isGod() code you used '=' and not '||=' in line 2191 so its resetting its state every time. I changed it from 

    $vars= $vars->{isGod}= {};

[download]

to 

    $vars= ( $vars->{isGod} ||= {} );

[download]

and it seems to be fine. The isApproved stuff OTOH appears to be problem free.

Thanks for applying the patches. :-)

---
$world=~s/war/peace/g

  • Comment on Re^3: Proposed new behaviour of isGods and isApproved (per session cache) (update deployed)
  • Select or Download Code

Replies are listed 'Best First'.
Re^4: Proposed new behaviour of isGods and isApproved (per session cache) (fix deployed)
by tye (Sage) on Sep 18, 2005 at 15:38 UTC

    Thanks. I've put that fix into production.

    These changes should kick up the site efficiency a notch. Good work, demerphq.

    - tye        

[reply]

In Section Inner Scriptorium