Why are you using the /e switch? This makes Perl think that you want to see the "replacement" part of s/// as a Perl expression. You likely want:

perl -pi.bak -e 's/site.type=standby/site.type=production/gi' /usr/loc
+al/jboss/conf/environment.properties
[download]