Assigning keys and values to a hash using arrays

dReKurCe has asked for the wisdom of the Perl Monks concerning the following question:

Greetings Monks:

I have a simple question regarding what I think requires a hash slice. The following code produces an output of:

Nlink 1
[download]

I would like to print all values and keys.
Any suggestions?

#! /usr/bin/perl

use warnings;
use strict;

my (%inf,@info,@keys,$phile,$key,$value);

use Cwd;
my $dir=Cwd->getcwd();
opendir(DIR,"$dir")or die "@!";
while ( $phile=readdir(DIR)){
        if($phile=~/^\.$/){next;}
        elsif($phile=~/^\.\.$/){next;}
        elsif($phile=~/^(.*)$/)
        {print "$phile\n";info($phile)}
        info ($phile);
        }

sub info{
         @info=stat($phile);
        @keys=qw(Dev Inode Mode NLink UID GID RDev Size               
+ATime CTime Blksize Blocks);

@inf{@keys}=@info;
}

($key,$value)=each %inf;
print "@info\n";
print "$key,$value";
[download]

Comment on Assigning keys and values to a hash using arrays Select or Download Code

Replies are listed 'Best First'.
Re: Assigning keys and values to a hash using arrays by Tanktalus (Canon) on Dec 06, 2005 at 14:25 UTC
First comment is style. This is not very readable as you've posted it. Some judicious use of whitespace would make this much easier for a human to parse, without making it any more difficult for the computer. Second, you should read the documentation on each. It has an example that shows pretty much the same idea: `while (($key,$value) = each %ENV) { print "$key=$value\n"; }` [download] You need to loop through "each" key/value rather than just the first. Third - your info function is going to overwrite the same global time after time. Is that really what you want? Your %inf will only hold the last file found. And finally, that last elsif will match anything. So I'm not sure why you have the "info ($phile)" outside of the if-elsif-elsif section.	[reply] [d/l]
Re: Assigning keys and values to a hash using arrays by blazar (Canon) on Dec 06, 2005 at 14:40 UTC
`my (%inf,@info,@keys,$phile,$key,$value);` [download] Generally no need to have such long declarations. Declare as close as possible to the actual use of the variable. `use Cwd; my $dir=Cwd->getcwd(); opendir(DIR,"$dir")or die "@!";` [download] `"@!"`?!? `while ( $phile=readdir(DIR)){ if($phile=~/^\.$/){next;} elsif($phile=~/^\.\.$/){next;}` [download] How 'bout `next if $phile =~ /.../;` [download] instead? Also, regexen are great, but how 'bout `next if $phile eq '.' or $phile eq '..';` [download] which is not exactly what you do, but is what I think you want to do. `elsif($phile=~/^(.)$/)` [download] "else if it matches anything else"...* `{print "$phile\n";info($phile)} info ($phile); }` [download] Huh?!? Twice? `sub info{ @info=stat($phile); @keys=qw(Dev Inode Mode NLink UID GID RDev Size ATime CTime Bl +ksize Blocks);` [download] Huh?!? Why passing it as a parameter if you use it as a "global"? Just adopt a proper form of the former option! (See perldoc perlsub) All in all if I understand correctly what you're after, it may be as simple as: #!/usr/bin/perl use strict; use warnings; use Data::Dumper; use Cwd; my $dir=Cwd->getcwd; opendir my $dh, $dir or die "Can't open `$dir': $!\n"; while (my $file=readdir $dh) { next if $file eq '.' or $file eq '..'; print $file, "\n"; my %tmp; @tmp{qw/Dev Inode Mode NLink UID GID RDev Size ATime CTime Blksize + Blocks/}= stat $file; print Dumper \%tmp; } __END__ [download] (using Data::Dumper for lazyness!)	[reply] [d/l] [select]
Re: Assigning keys and values to a hash using arrays by dReKurCe (Scribe) on Dec 06, 2005 at 18:27 UTC
Greets: Thanks for the quick response, this script contained some silly errors and oversights, I appreciate your patience. I did manage to accomplish what I wanted: the code is on my scratchpad. dReKurCe's scratchpad	[reply]