use strict;
use warnings;
...

open MATCHING_FILE, $TEXT_FILE;
my %seen;
while (my $file = <MATCHING_FILE>){
    chomp $file;
    if ( $file =~ /[\d]{1,3}\.[\d]{1,3}\.[\d]{1,3}\.[\d]{1,3}|password
+|(ssn=)/i){
        $seen{$file}++;
    }
}

print "$_\n" for keys %seen;
[download]

Update: fixed copy&paste error, Roy Johnson++

I can't tell what you're trying to do here, so it's hard to say what to suggest. However, a couple of things stand out.

        @results = $each_line;
        %hashTemp = map { @results => 1 } @results;
[download]

The first line there is trying to put a scalar into an array. You'll have an array with one element, which may not be what you want. If you want to add to the array, look at push and unshift.

The second line seems to be trying to get the unique elements from @results, but the map block is wrong for that.

This may be what you're shooting for:

        push @results, $each_line;
        %hashTemp = map { $_ => 1 } @results;
[download]

However, I'm guessing that everything after the push should be outside the for loop, and maybe outside sub edits. That depends on what you're ultimately trying to accomplish.

Also, I think sub edits() could be sub edits. The former creates a sub with a prototype, and you probably don't want that.

Finally, I think it would be a really good idea to use strict and warnings.

I think, at least, that you want @results = $each_line to be push @results, $each_line. And %array_out should be @array_out. All the hash processing most likely goes after the for loop.

use strict;
use warnings;
[download]

Thanks for the quick replies. Here is the code that I have at the moment. This is currently working and I get the desired results (except for the fact that I get duplicates). I have also updated the code with some of your recommendations.

#!/usr/bin/perl
use strict;
use warnings;

use File::Find;
my $DIRECTORY = "/Users/data/";
find(\&edits, $DIRECTORY);
sub edits()
{
 if ( -f and /.txt$/ ) {  #Find files ending in .txt and drill down al
+l sub dirs
   my $TEXT_FILE = $_; #save the results to $_;
   open MATCHING_FILE, $TEXT_FILE;
   my @all_lines = <MATCHING_FILE>; #Place everything into an array ca
+ll all_lines
   close MATCHING_FILE;
   for my $each_line ( @all_lines ) {
     if ( $each_line =~ /[\d]{1,3}\.[\d]{1,3}\.[\d]{1,3}\.[\d]{1,3}|pa
+ssword|(ssn=)/i ) { #Search for IP or password or ssn=
       #print $each_line, "Found in $File::Find::name\n";
       print $each_line; # Print each line that is found
       }
     }
   }
 }
[download]

Results from all files in a directory
192.168.1.1
192.168.1.1
192.168.1.1
64.22.34.66
221.245.23.44
PASSWORD=FpnmRjE
[download]

what I want to do is remove the 192.168.1.1 dups from being printed along with all the other dups that show up.

This is a faq. See perldoc4, near unique. I also find the following entries when googling for perl unique:

• Recipe 4.6. Extracting Unique Elements from a List (in the Perl Cookbook, no link from here)
• How can I extract just the unique elements of an array?

... and some more. I wonder whether you've seen these links and what parts of the solutions presented there you had problems with.

one quick note glancing at this:


• use /\.txt$/ (not /.txt$/) to be exact... altho the latter will probably work in this context, consider the difference between \. and .

You can simplify your long regexp with :


use Regexp::Common qw /net/;

/\A $RE{net}{IPv4} | password | (ssn=) \z/xmi;
[download]

hth,

PooLpi


'Ebry haffa hoe hab im tik a bush'. Jamaican proverb

Update: Oops,if it's a succession of alternatives : moritz++ ;)
I also forgot the /m