in reply to Sort/Uniq Help

There are a lot of weird things in that code, which makes it hard to figure out how to fix it. If you'd put comments in to indicate what you expect each line or tightly-related group of lines to do, it would be easier. It might also cause you to see some things that don't make sense.

I think, at least, that you want @results = $each_line to be push @results, $each_line. And %array_out should be @array_out. All the hash processing most likely goes after the for loop. 

use strict;
use warnings;

[download]
would be your friends here, as well.
Caution: Contents may have been coded under pressure.

Replies are listed 'Best First'.
Re^2: Sort/Uniq Help
by learningperl01 (Beadle) on Mar 17, 2008 at 18:09 UTC
    Thanks for the quick replies. Here is the code that I have at the moment. This is currently working and I get the desired results (except for the fact that I get duplicates). I have also updated the code with some of your recommendations. 
    #!/usr/bin/perl
use strict;
use warnings;

use File::Find;
my $DIRECTORY = "/Users/data/";
find(\&edits, $DIRECTORY);
sub edits()
{
 if ( -f and /.txt$/ ) {  #Find files ending in .txt and drill down al
+l sub dirs
   my $TEXT_FILE = $_; #save the results to $_;
   open MATCHING_FILE, $TEXT_FILE;
   my @all_lines = <MATCHING_FILE>; #Place everything into an array ca
+ll all_lines
   close MATCHING_FILE;
   for my $each_line ( @all_lines ) {
     if ( $each_line =~ /[\d]{1,3}\.[\d]{1,3}\.[\d]{1,3}\.[\d]{1,3}|pa
+ssword|(ssn=)/i ) { #Search for IP or password or ssn=
       #print $each_line, "Found in $File::Find::name\n";
       print $each_line; # Print each line that is found
       }
     }
   }
 }

    [download]
    Results from all files in a directory
192.168.1.1
192.168.1.1
192.168.1.1
64.22.34.66
221.245.23.44
PASSWORD=FpnmRjE

    [download]
    what I want to do is remove the 192.168.1.1 dups from being printed along with all the other dups that show up.
[reply]
[d/l]
[select]
[reply]
      one quick note glancing at this:

    • use /\.txt$/ (not /.txt$/) to be exact... altho the latter will probably work in this context, consider the difference between \. and .
[reply]

      You can simplify your long regexp with :

      use Regexp::Common qw /net/;

/\A $RE{net}{IPv4} | password | (ssn=) \z/xmi;

      [download]

      hth,

      PooLpi

      'Ebry haffa hoe hab im tik a bush'. Jamaican proverb

      Update: Oops,if it's a succession of alternatives : moritz++ ;)
      I also forgot the /m

[reply]
[d/l]
        I know that TheDamian recommends character classes to escape chars in regexes (in PBP), but it's generally a bad idea because it will disable some optimizations (at least in older versions of perl, don't know about current ones).

        Also \| is shorten than [|], and thus less noise that your brain has to parse.

        But in the original post the | isn't escaped at all, so you're actually modifiying the behaviour of the regex.

[reply]
[d/l]
[select]

In Section Seekers of Perl Wisdom