Re: Problem with regex

A couple of points not related to your issue with the regex.

From a style and a code maintenance point of view, it might be better to move the closedir(TEMP); line up to immediately after the my @FILES=readdir(TEMP); line since you've done with reading the directory handle at that point.

It is now considered good practice to use the three-argument form of open with lexical filehandles and, when testing for success as you do (well done ++), it is useful to output the O/S error $! (see perlvar).

It is perhaps better to use Perl-style for loops rather than C-style ones. You can use for and foreach interchangeably. Instead of

my $fi = scalar (@FILES);
for (my $k = 0; $k < $fi ; $k++)
  {
     open (F,$FILES[$k]) or die " rey ledhu ra \n";
     ...
  };
[download]

use

foreach my $file ( @FILES )
{
    open my $inFH, '<', $file
       or die "open: < $file: $!\n";
    ...
}
[download]

I hope this is of interest.

Cheers,

JohnGG

Comment on Re: Problem with regex Select or Download Code

Replies are listed 'Best First'.
Re^2: Problem with regex by mpeever (Friar) on Sep 16, 2008 at 13:56 UTC
I would actually suggest forgoing the loop altogether and using grep: `my @FILES = grep { -f } readdir (TEMP); foreach my $file (@FILES){ open (F, $file) or warn "Couldn't open $file: $!" and next; my @matches = grep { /$str/ } <F>; close (F); next unless scalar @matches > 0; print join("\n", @matches); }` [download] Of course, that prints every matching line in the file, if you only want the first (evidenced by "last"), you could just use: `print $matches[0], "\n";` [download] And do you really want to use "die" in a loop? What if you can't open one file, but you can open the rest? Isn't "warn and next" more appropriate?	[reply] [d/l] [select]
Re^3: Problem with regex by johngg (Canon) on Sep 16, 2008 at 14:49 UTC
I would actually suggest forgoing the loop altogether and using grep Nothing wrong with using grep to fill the `@FILES` array, although I might do `grep { -f and not -l }` depending on how symlinks should be treated. However, unless my eyes are failing me, you still have the loop in your code. And do you really want to use "die" in a loop? The OP seems to and, since I don't know what the requirements are, I followed his/her lead. Cheers, JohnGG	[reply] [d/l] [select]
Re^4: Problem with regex by mpeever (Friar) on Sep 16, 2008 at 17:11 UTC
Your eyes are not failing you! I clearly should have said I would use fewer loops... my bad! We could wrap the loop in a "map" but I don't think it would add to the clarity of the code, so it's probably not worth doing. But I generally find list operators easier to read than nested loops.	[reply]