in reply to Re: Lady Aleena's first working module
in thread Lady Aleena's first working module

Tux,

With what Herkum suggested in Re: Lady Aleena's first working module, using a hash instead of a lot of arrays, I was able to cut down on the redundant code a bit. You can see my changes in Re^2: Lady Aleena's first working module. I am a bit confused as to why you would put the closing bracket of the if on the next level down from it. I am of the mind that the closing bracket should be on the same level as where it was opened. I am also not a big fan of condensing the if, but that is because I don't want it to get lost. That is the same reason I concatenate over interpolate.

Have a nice day!
Lady Aleena

Replies are listed 'Best First'.
Re^3: Lady Aleena's first working module
by Tux (Canon) on Oct 15, 2009 at 06:20 UTC

    In my humble but very honest opinion, indenting the closing brace to that level is the only logical thing to do. I have tried to explain that (and some other style issues) in here. I know many won't agree, but you have to admit I at least gave it a lot of thought and I'm not one of those people that just blindly follow what their favourite editor thinks to be the best style today.


    Enjoy, Have FUN! H.Merijn