You already have an open thread with the same title and similar code Perl Subroutine. How do I compose an effective node title? is worth reading and understanding, along with How do I post a question effectively?. Both of these links are displayed each time you post.