in reply to Reading Multiple Input Files

  1. Put the filenames in an array, say @filenames
  2. Put a for my $file1 (@filenames) { ... } around your existing code (the ... is to be replaced by your code)
  3. Delete the $file1 = '../filename.asc'; line
Ready!

Then try to add the strictures use strict; use warnings; and amend your code until all errors and warnings disappear.

You may want to look into the three argument version of open.

Finally, perhaps you need to change the output filenames so they do not get overwritten by the next file.

CountZero

A program should be light and agile, its subroutines connected like a string of pearls. The spirit and intent of the program should be retained throughout. There should be neither too little or too much, neither needless loops nor useless variables, neither lack of structure nor overwhelming rigidity." - The Tao of Programming, 4.1 - Geoffrey James

Replies are listed 'Best First'.
Re^2: Reading Multiple Input Files
by BoulderBuff64 (Novice) on May 27, 2011 at 22:32 UTC

    Good call! I used 

    for ($i=0; $i<$Num_of_Files; $i++) {
open(Read, $file[$i]);
@Read = <Read>; 
...}

    [download]

    I used this instead of for my $file1 (@filenames) { ... } so I could assign a name for each of the output files.

    A coworker suggested that I use use strict but I don't see the usefulness of this. Why do you use it?

[reply]
[d/l]
[select]
      I had a node around here about why to use strict....

      Ah, here it is -- On Commenting Out 'use strict;' .... It's a tad dusty, I wrote it three or four jobs back, but it is still applicable.

      ----
      I Go Back to Sleep, Now.

      OGB

[reply]
[d/l]
      Ouch, C-style for loops in Perl.

      A more Perlish approach is

      while ( my ($index, $file) = each @filenames) {... }

      [download]

      No need to calculate the number of files, you don't need to use indexes to access the filename and you still have the $index variable to use in composing the output filenames.

      CountZero

      A program should be light and agile, its subroutines connected like a string of pearls. The spirit and intent of the program should be retained throughout. There should be neither too little or too much, neither needless loops nor useless variables, neither lack of structure nor overwhelming rigidity." - The Tao of Programming, 4.1 - Geoffrey James

[reply]
[d/l]
[select]
[reply]
[reply]

In Section Seekers of Perl Wisdom