in reply to list item comparison

This subroutine accepts a list of numbers, and returns a list of hashrefs that look like: { $number => [ $idx1, $idx2, $idx_n, ... ] }, where each index represents where that particular number will be found in the original list.

use strict; use warnings; use Data::Dump 'dump'; my @numbers = ( 1, 2, 2, 4, 8, 42, 7, 2, 6, 7, 9, 42 ); my @duplicate_locations = find_duplicates( @numbers ); dump @duplicate_locations; sub find_duplicates { my @list = @_; my $idx; my %buckets; foreach my $item ( @list ) { push @{$buckets{$item}}, $idx++; } my @rv; foreach my $key ( keys %buckets ) { push @rv, { $list[$buckets{$key}->[0]] => $buckets{$key} } if @{$buckets{$key}} > 1; } return @rv; }

The output...

({ 42 => [5, 11] }, { 7 => [6, 9] }, { 2 => [1, 2, 7] })

Update:Simplifying the data structure returned simplifies the subroutine that produces it:

use strict; use warnings; use Data::Dump 'dump'; my @numbers = ( 1, 2, 2, 4, 8, 42, 7, 2, 6, 7, 9, 42 ); dump { find_duplicates( @numbers ) }; sub find_duplicates { my @list = @_; my $idx; my %buckets; foreach my $item ( @list ) { push @{$buckets{$item}}, $idx++; } delete @buckets{ grep { @{$buckets{$_}} < 2 } keys %buckets }; return %buckets; }

Now the output is...

{ 2 => [1, 2, 7], 7 => [6, 9], 42 => [5, 11] }

...so the actual return value from the sub is a hash where the keys are the values from your original list, and the values are array refs containing lists of where the corresponding elements are found. ...and we've stripped away any that weren't duplicated.


Dave

Replies are listed 'Best First'.
Re^2: list item comparison
by robertw (Sexton) on Jul 13, 2012 at 00:55 UTC

    Thanks a lot you guys thats great coding, I will definately not need more than this, what i had so far was this, but your scripts definately beat it, although i made it if this is unequal put it in this list just to get more understanding of what i had to do.

    foreach @allcards { if $allcards[$count] != @userinput[0] or if $allcards[$count] != @userinput[1] or if $allcards[$count] != @userinput[2] or if $allcards[$count] != @userinput[3] or if $allcards[$count] != @userinput[4] or if $allcards[$count] != @userinput[5] { push (@resthand,$allcards[$count]); } count++;}