in reply to Re^2: Adding only searched values to array ref
in thread Adding only searched values to array ref
Update: As ++AnomalousMonk points out, my "solution" had the wrong sense on the compare! It should be ne instead of == just as he suggested.
I put the my original code into readmore brackets. The new code with one line of code + comments changed is below.
Note this brings up the issue of whether or not a duplication can occur of a record already in the $all array? see below.
Update2:use strict; use warnings; use Data::Dump qw (pp); my $accounts = [ { 'date' => '1980-03-05', 'year' => '2019', 'acc' => '44443', }, { 'date' => '1999-06-19', 'year' => '2017', 'acc' => '54321', }, { 'date' => '1999-09-19', 'year' => '2099', 'acc' => '12345', }, ]; my $all = [ { 'date' => '2000-01-00', 'year' => '2003', 'acc' => '4327', }, { 'date' => '1987-01-03', 'year' => '2013', 'acc' => '89997', }, { 'date' => '1980-04-18', 'year' => '2016', 'acc' => '239876A', }, { 'date' => '1999-06-19', 'year' => '2017', 'acc' => '54321', } ]; # add all hashes from $accounts to $all, but # exclude account 44443, if it is there foreach my $href (@$accounts) { push @$all, $href if $href->{acc} ne '44443'; #note string compar +e } pp $all; __END__ [ { acc => 4327, date => "2000-01-00", year => 2003 }, { acc => 89997, date => "1987-01-03", year => 2013 }, { acc => "239876A", date => "1980-04-18", year => 2016 }, { acc => 54321, date => "1999-06-19", year => 2017 }, { acc => 54321, date => "1999-06-19", year => 2017 }, { acc => 12345, date => "1999-09-19", year => 2099 }, ] Note: account OP's test $account data did contain a record that alread +y exists in the $all array. This results in a duplicate record. See acc=> 54321 above. There are of course ways to prevent that duplication. Before suggesting code for that, I'd like to hear from the OP whether this can really happen in "the real world" and if such a solution is even needed.
It is perfectly ok for the input and the output of a grep to be the same array. Perl will keep it straight so that it doesn't "write over its own input".
Of course this can also be formulated using an explicit for loop.# make the @$all array the union of everything in # either @$all or @$accounts, excluding the acc 44443 record # (if it exists at all) and exclude any possible duplicates # This "zaps" the duplicate 54321 record. # This literally says, "transfer the input to the output if # the input record isn't about account 44443 and we haven't # already transferred that record to the output before. # This assumes that records are uniquely id'ed by the acc # number. That might or might not be true in the actual # application. my %seen; @$all = grep{ $_->{acc} ne '44443' and !$seen{$_->{acc}}++ } @$all,@$a +ccounts;
use strict; use warnings; use Data::Dump qw (pp); my $accounts = [ { 'date' => '1980-03-05', 'year' => '2019', 'acc' => '44443', }, { 'date' => '1999-06-19', 'year' => '2017', 'acc' => '54321', }, { 'date' => '1999-09-19', 'year' => '2099', 'acc' => '12345', }, ]; my $all = [ { 'date' => '2000-01-00', 'year' => '2003', 'acc' => '4327', }, { 'date' => '1987-01-03', 'year' => '2013', 'acc' => '89997', }, { 'date' => '1980-04-18', 'year' => '2016', 'acc' => '239876A', }, { 'date' => '1999-06-19', 'year' => '2017', 'acc' => '54321', } ]; # add all hashes from $accounts to $all if # the acc == 44443 foreach my $href (@$accounts) { push @$all, $href if $href->{acc} == 44443; } pp $all; __END__ [ { acc => 4327, date => "2000-01-00", year => 2003 }, { acc => 89997, date => "1987-01-03", year => 2013 }, { acc => "239876A", date => "1980-04-18", year => 2016 }, { acc => 54321, date => "1999-06-19", year => 2017 }, { acc => 44443, date => "1980-03-05", year => 2019 }, ]
|
|---|
| Replies are listed 'Best First'. | |
|---|---|
|
Re^4: Adding only searched values to array ref
by AnomalousMonk (Archbishop) on Sep 22, 2021 at 11:03 UTC | |
by Marshall (Canon) on Sep 22, 2021 at 22:06 UTC |