in reply to grep and find file weirdness

Here is some advice try something like:
#!/usr/bin/perl -l use strict; use File::Find; use File::Spec; use constant DIRECTORY => '/tmp/rja/find_test'; my @files; find( \&findsub, __PACKAGE__->DIRECTORY ); @files = grep is_dos_format($_), @files; foreach my $file (@files) { print "FAILED FILE - $file"; } sub findsub { push @files, $File::Find::name; } sub is_dos_format { my $abs_path = shift; open ( my $fh, '<', $abs_path ) or die "open $abs_path: $!" ; if ( grep m/\r\n/s, <$fh> ) { return 1; } return undef; }


Evan Carroll
www.EvanCarroll.com

Replies are listed 'Best First'.
Re^2: grep and find file weirdness
by blazar (Canon) on Jun 20, 2007 at 19:45 UTC
    I think reading in the whole file is probably better for whatever you want, on a modern system

    I don't think so. It may not do a big difference, on a modern system. But under certain circumstances it may even there. After all he wants to quit searching as soon as /\r\n/ matches: what benefit would he have going on instead?