I think reading in the whole file is probably better for whatever you want, on a modern system

I don't think so. It may not do a big difference, on a modern system. But under certain circumstances it may even there. After all he wants to quit searching as soon as /\r\n/ matches: what benefit would he have going on instead?