in reply to Help in using arrays

If you are going to revisit a previous question then you should, at least, include a link to the earlier discussion so that we can see what advice has already been offered and ignored.

Update: I've now taken a closer look at your code and I can't see the problem that you are having. The code below is based on your code above and has been expanded to create a standalone program. It seems to work as expected and print out the whole line. I therefore suspect that your problem is in the bits of your code that you aren't showing us.

#!/usr/bin/perl use strict; use warnings; my @all = qw(7723 7725 9908 7765 7874); while (<DATA>) { for my $x (0..$#all) { if($_ =~ /$all[$x]/) { print $_; } } } __DATA__ 77876 8543 CA84985 54E 77873 8003 CA84985 54E 77875 7725 CA84985 54E 77872 8511 CA84985 54E 77873 8123 CA84985 54E 77822 9908 CA84985 54E 77819 8503 CA84985 54E 77826 8040 CA84985 54E 77822 7874 CA84985 54E 77884 8543 CA84985 54E 77809 7211 CA84985 54E

And the output I get is:

77875 7725 CA84985 54E 77822 9908 CA84985 54E 77822 7874 CA84985 54E

There is, of course, a potential bug in this code as it checks for the existance of your numbers anywhere in a line of input and you specifically want to check for it in the second column. You can therefore change the central loop of my code to look lie this (and note that I've also been able to change the match operator to an equality operator).

while (<DATA>) { my $code = (split)[1]; for my $x (0..$#all) { if($code eq $all[$x]) { print $_; } } }

Finally, there's no point in checking for more than one match, so it's worth exiting the inner loop once a match is found.

while (<DATA>) { my $code = (split)[1]; for my $x (0..$#all) { if($code eq $all[$x]) { print $_; last; } } }

Replies are listed 'Best First'.
Re^2: Help in using arrays
by Anno (Deacon) on Mar 14, 2007 at 14:42 UTC
    Your code suggestion:
    while (<DATA>) { my $code = (split)[1]; for my $x (0..$#all) { if($code eq $all[$x]) { print $_; last; } } }
    I suppose you have written it this way to stay close to the OP's coding style, but it should be mentioned that indexing the @all array is not necessary and not particularly perlish.
    while (<DATA>) { my $code = (split)[1]; for my $x ( @all ) { if($code eq $x) { print $_; last; } } }
    Now it becomes apparent that what the loop does is really a grep operation:
    while (<DATA>) { my $code = (split)[1]; print if grep $_ eq $code, @all; } }
    Finally, it turns out that grep can be replaced with a hash lookup when the list @all is replaced by a hash:
    my %all = map +( $_ => 1), qw(7723 7725 9908 7765 7874); $all{ (split)[ 1]} and print while <DATA>;
    Anno

    Update: Stylistic change, pomposity tuned down a notch.

        Just one small point. At the point when you switch to using "grep", you lose the tiny optimisation that you get from using "last" in the loop.

        Indeed. I thought of mentioning it, but that seemed to invite a deviation to List::Util::first and I dropped the whole thing.

        Anno