Duh, of course. Thanks for catching that. Doing it at the comparison point is wrong though, the real fix is to de-escape the URI encoding for cookie data when it's parsed. That means simply:
--- pmchatter.html.old 2004-12-19 17:05:59.000000000 +0100
+++ pmchatter.html 2004-12-19 17:05:13.000000000 +0100
@@ -17,3 +17,3 @@
var kv = record[ i ].split( /=/ );
- this.data[ kv[ 0 ] ] = kv[ 1 ];
+ this.data[ decodeURIComponent( kv[ 0 ] ) ] = d
+ecodeURIComponent( kv[ 1 ] );
}
@@ -63,3 +63,3 @@
if( userpass.length ) {
- req.setRequestHeader( 'Cookie', 'userpass=' + userpass
+ );
+ req.setRequestHeader( 'Cookie', 'userpass=' + encodeUR
+IComponent( userpass ) );
}
I updated the root node.
Update: it wasn't quite as trivial — need to re-escape the cookie to send it, of course.
Makeshifts last the longest.
|