No such thing as a small change | |
PerlMonks |
Re: grep and find file weirdnessby blazar (Canon) |
on Jun 20, 2007 at 19:40 UTC ( [id://622373]=note: print w/replies, xml ) | Need Help?? |
Anywho, here's the distilled example... In addition to the other good suggestions you got (I hope not to repeat too many of them!) here are a few others:
No need for the initialization and it doesn't add to clarity IMHO.
Rather than collecting filenames in @files to process the latter with grep later, why don't you do so in the first place as files are being searched? If the files are many, then your program should be more responsive. Also, I don't understand the logic of stripping the base directory only to reinsert it later...
Oh, and why another loop too?!? (grep is one in disguise: you're doing it twice when there's no logical reason to.)
The whole point of the $_ pronoun is that it is the topicalizer: you either use an explicit variable name and the binding operator or just the match. All in all I believe your code may be rewritten like:
In Section
Seekers of Perl Wisdom
|
|