I am very frustrated in that your patch looks simpler than
my attempt, and yet I'm not sure I understand, probably
because the AvMAX() and AvFILLp() don't
seem to be documented well enough for me to figure out what
they're doing.
if (num) {
i = AvFILLp(av);
/* Create extra elements */
/**/ slide = i > 0 ? i : 0;
/**/ num += slide;
av_extend(av, i + num);
AvFILLp(av) += num;
ary = AvARRAY(av);
Move(ary, ary + num, i + 1, SV*);
do {
ary[--num] = &PL_sv_undef;
} while (num);
/* Make extra elements into a buffer */
/**/ AvMAX(av) -= slide;
/**/ AvFILLp(av) -= slide;
SvPVX(av) = (char*)(AvARRAY(av) + slide);
}
}
Why do you add num to AvFILLp() (which is
the original num with slide added to it)
only to then SUBTRACT slide? And what is
AvMAX()?!
And I would personally suggest using the heuristic for slide
that I had in my code -- namely:
slide = (i < num && i > 0) ? i : num;
Anyway. Sigh. I'm not annoyed at you, but at my inability
to patch something that shouldn't have been such a well of
annoyance.
japhy --
Perl and Regex Hacker
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|